Commit 82126e59 authored by Chris Wilson's avatar Chris Wilson

drm/i915/gt: Drop the timeline->mutex as we wait for retirement

As we have pinned the timeline (using tl->active_count), we can safely
drop the tl->mutex as we wait for what we believe to be the final
request on that timeline. This is useful for ensuring that we do not
block the engine heartbeat by hogging the kernel_context's timeline on a
dead GPU.

References: https://gitlab.freedesktop.org/drm/intel/issues/1364
Fixes: 058179e7 ("drm/i915/gt: Replace hangcheck by heartbeats")
Fixes: f33a8a51 ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200303140009.1494819-1-chris@chris-wilson.co.uk
parent 2f000308
...@@ -147,24 +147,32 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout) ...@@ -147,24 +147,32 @@ long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout)
fence = i915_active_fence_get(&tl->last_request); fence = i915_active_fence_get(&tl->last_request);
if (fence) { if (fence) {
mutex_unlock(&tl->mutex);
timeout = dma_fence_wait_timeout(fence, timeout = dma_fence_wait_timeout(fence,
interruptible, interruptible,
timeout); timeout);
dma_fence_put(fence); dma_fence_put(fence);
/* Retirement is best effort */
if (!mutex_trylock(&tl->mutex)) {
active_count++;
goto out_active;
}
} }
} }
if (!retire_requests(tl) || flush_submission(gt)) if (!retire_requests(tl) || flush_submission(gt))
active_count++; active_count++;
mutex_unlock(&tl->mutex);
spin_lock(&timelines->lock); out_active: spin_lock(&timelines->lock);
/* Resume iteration after dropping lock */ /* Resume list iteration after reacquiring spinlock */
list_safe_reset_next(tl, tn, link); list_safe_reset_next(tl, tn, link);
if (atomic_dec_and_test(&tl->active_count)) if (atomic_dec_and_test(&tl->active_count))
list_del(&tl->link); list_del(&tl->link);
mutex_unlock(&tl->mutex);
/* Defer the final release to after the spinlock */ /* Defer the final release to after the spinlock */
if (refcount_dec_and_test(&tl->kref.refcount)) { if (refcount_dec_and_test(&tl->kref.refcount)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment