Commit 8278fae5 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: legacy: add initialized flag

Add initialized flag and use instead of the connection protocol pointer
to determine when the legacy connection has been initialised.

This is a step in moving legacy connection binding to
connection-creation time.
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 431b3ebb
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
struct legacy_connection { struct legacy_connection {
struct gb_connection *connection; struct gb_connection *connection;
bool initialized;
}; };
struct legacy_data { struct legacy_data {
...@@ -112,6 +113,8 @@ static int legacy_connection_init(struct legacy_connection *lc) ...@@ -112,6 +113,8 @@ static int legacy_connection_init(struct legacy_connection *lc)
if (ret) if (ret)
goto err_disable; goto err_disable;
lc->initialized = true;
return 0; return 0;
err_disable: err_disable:
...@@ -126,7 +129,7 @@ static void legacy_connection_exit(struct legacy_connection *lc) ...@@ -126,7 +129,7 @@ static void legacy_connection_exit(struct legacy_connection *lc)
{ {
struct gb_connection *connection = lc->connection; struct gb_connection *connection = lc->connection;
if (!connection->protocol) if (!lc->initialized)
return; return;
gb_connection_disable(connection); gb_connection_disable(connection);
...@@ -134,6 +137,8 @@ static void legacy_connection_exit(struct legacy_connection *lc) ...@@ -134,6 +137,8 @@ static void legacy_connection_exit(struct legacy_connection *lc)
connection->protocol->connection_exit(connection); connection->protocol->connection_exit(connection);
legacy_connection_unbind_protocol(connection); legacy_connection_unbind_protocol(connection);
lc->initialized = false;
} }
static int legacy_connection_create(struct legacy_connection *lc, static int legacy_connection_create(struct legacy_connection *lc,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment