Commit 828857f6 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Hans de Goede

platform/x86: asus-wmi: Fix "unsigned 'retval' is never less than zero" smatch warning

Eliminate the follow smatch warnings:

drivers/platform/x86/asus-wmi.c:478 panel_od_write() warn: unsigned
'retval' is never less than zero.

drivers/platform/x86/asus-wmi.c:566 panel_od_write() warn: unsigned
'retval' is never less than zero.

drivers/platform/x86/asus-wmi.c:1451 panel_od_write() warn: unsigned
'retval' is never less than zero.
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: 98829e84 ("asus-wmi: Add dgpu disable method")
Fixes: 382b91db ("asus-wmi: Add egpu enable method")
Fixes: ca91ea34 ("asus-wmi: Add panel overdrive functionality")
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1629887822-23918-1-git-send-email-jiapeng.chong@linux.alibaba.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent b72067c6
......@@ -475,7 +475,7 @@ static int dgpu_disable_write(struct asus_wmi *asus)
return err;
}
if (retval > 1 || retval < 0) {
if (retval > 1) {
pr_warn("Failed to set dgpu disable (retval): 0x%x\n", retval);
return -EIO;
}
......@@ -563,7 +563,7 @@ static int egpu_enable_write(struct asus_wmi *asus)
return err;
}
if (retval > 1 || retval < 0) {
if (retval > 1) {
pr_warn("Failed to set egpu disable (retval): 0x%x\n", retval);
return -EIO;
}
......@@ -1448,7 +1448,7 @@ static int panel_od_write(struct asus_wmi *asus)
return err;
}
if (retval > 1 || retval < 0) {
if (retval > 1) {
pr_warn("Failed to set panel overdrive (retval): 0x%x\n", retval);
return -EIO;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment