Commit 83360eb7 authored by Dmitry Bogdanov's avatar Dmitry Bogdanov Committed by Greg Kroah-Hartman

net: aquantia: fix out of memory condition on rx side

[ Upstream commit be6cef69 ]

On embedded environments with hard memory limits it is a normal although
rare case when skb can't be allocated on rx part under high traffic.

In such OOM cases napi_complete_done() was not called.
So the napi object became in an invalid state like it is "scheduled".
Kernel do not re-schedules the poll of that napi object.

Consequently, kernel can not remove that object the system hangs on
`ifconfig down` waiting for a poll.

We are fixing this by gracefully closing napi poll routine with correct
invocation of napi_complete_done.

This was reproduced with artificially failing the allocation of skb to
simulate an "out of memory" error case and check that traffic does
not get stuck.

Fixes: 970a2e98 ("net: ethernet: aquantia: Vector operations")
Signed-off-by: default avatarIgor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: default avatarDmitry Bogdanov <dmitry.bogdanov@aquantia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 30c345bd
...@@ -89,6 +89,7 @@ static int aq_vec_poll(struct napi_struct *napi, int budget) ...@@ -89,6 +89,7 @@ static int aq_vec_poll(struct napi_struct *napi, int budget)
} }
} }
err_exit:
if (!was_tx_cleaned) if (!was_tx_cleaned)
work_done = budget; work_done = budget;
...@@ -98,7 +99,7 @@ static int aq_vec_poll(struct napi_struct *napi, int budget) ...@@ -98,7 +99,7 @@ static int aq_vec_poll(struct napi_struct *napi, int budget)
1U << self->aq_ring_param.vec_idx); 1U << self->aq_ring_param.vec_idx);
} }
} }
err_exit:
return work_done; return work_done;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment