Commit 83476bfa authored by Wei Yongjun's avatar Wei Yongjun Committed by Thierry Reding

iommu/tegra-smmu: Fix return value check in tegra_smmu_group_get()

In case of error, the function iommu_group_alloc() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 7f4c9176 ("iommu/tegra: Allow devices to be grouped")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 7f4c9176
......@@ -832,7 +832,7 @@ static struct iommu_group *tegra_smmu_group_get(struct tegra_smmu *smmu,
group->soc = soc;
group->group = iommu_group_alloc();
if (!group->group) {
if (IS_ERR(group->group)) {
devm_kfree(smmu->dev, group);
mutex_unlock(&smmu->lock);
return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment