Commit 83761f96 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones

mfd: sec-core: Return gracefully instead of BUG() if device cannot match

Replace impossible BUG() in probe with a proper return.  This can be
triggered only in case of a clear bug (e.g. adding broken half-support
for new S2MPSXX flavor) but BUG() is discouraged and the boot process
can actually try to continue.
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 9f208eca
...@@ -471,8 +471,9 @@ static int sec_pmic_probe(struct i2c_client *i2c, ...@@ -471,8 +471,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
num_sec_devs = ARRAY_SIZE(s2mpu02_devs); num_sec_devs = ARRAY_SIZE(s2mpu02_devs);
break; break;
default: default:
/* If this happens the probe function is problem */ dev_err(&i2c->dev, "Unsupported device type (%lu)\n",
BUG(); sec_pmic->device_type);
return -ENODEV;
} }
ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs,
NULL, 0, NULL); NULL, 0, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment