Commit 837a5584 authored by Daisuke Matsuda's avatar Daisuke Matsuda Committed by Leon Romanovsky

RDMA/rxe: Implement packet length validation on responder

The function check_length() is supposed to check the length of inbound
packets on responder, but it actually has been a stub since the driver was
born. Let it check the payload length and the DMA length.
Signed-off-by: default avatarDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Link: https://lore.kernel.org/r/20221107055338.357184-1-matsuda-daisuke@fujitsu.comReviewed-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Acked-by: default avatarZhu Yanjun <zyjzyj2000@gmail.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent bdf1da5d
...@@ -393,16 +393,36 @@ static enum resp_states check_resource(struct rxe_qp *qp, ...@@ -393,16 +393,36 @@ static enum resp_states check_resource(struct rxe_qp *qp,
static enum resp_states check_length(struct rxe_qp *qp, static enum resp_states check_length(struct rxe_qp *qp,
struct rxe_pkt_info *pkt) struct rxe_pkt_info *pkt)
{ {
switch (qp_type(qp)) { int mtu = qp->mtu;
case IB_QPT_RC: u32 payload = payload_size(pkt);
return RESPST_CHK_RKEY; u32 dmalen = reth_len(pkt);
case IB_QPT_UC: /* RoCEv2 packets do not have LRH.
return RESPST_CHK_RKEY; * Let's skip checking it.
*/
default: if ((pkt->opcode & RXE_START_MASK) &&
return RESPST_CHK_RKEY; (pkt->opcode & RXE_END_MASK)) {
/* "only" packets */
if (payload > mtu)
return RESPST_ERR_LENGTH;
} else if ((pkt->opcode & RXE_START_MASK) ||
(pkt->opcode & RXE_MIDDLE_MASK)) {
/* "first" or "middle" packets */
if (payload != mtu)
return RESPST_ERR_LENGTH;
} else if (pkt->opcode & RXE_END_MASK) {
/* "last" packets */
if ((payload == 0) || (payload > mtu))
return RESPST_ERR_LENGTH;
}
if (pkt->opcode & (RXE_WRITE_MASK | RXE_READ_MASK)) {
if (dmalen > (1 << 31))
return RESPST_ERR_LENGTH;
} }
return RESPST_CHK_RKEY;
} }
static enum resp_states check_rkey(struct rxe_qp *qp, static enum resp_states check_rkey(struct rxe_qp *qp,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment