Commit 83863a26 authored by Tan, Tee Min's avatar Tan, Tee Min Committed by Greg Kroah-Hartman

net: stmmac: fix ethtool flow control not able to get/set

Currently ethtool was not able to get/set the flow control due to a
missing "!". It will always return -EOPNOTSUPP even the device is
flow control supported.

This patch fixes the condition check for ethtool flow control get/set
function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.

Fixes: 3c1bcc86 (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”)
Signed-off-by: default avatarTan, Tee Min <tee.min.tan@intel.com>
Reviewed-by: default avatarOng Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Voon, Weifeng <weifeng.voon@intel.com@intel.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7fb188ef
...@@ -460,7 +460,7 @@ stmmac_get_pauseparam(struct net_device *netdev, ...@@ -460,7 +460,7 @@ stmmac_get_pauseparam(struct net_device *netdev,
} else { } else {
if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT, if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
netdev->phydev->supported) || netdev->phydev->supported) ||
linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, !linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
netdev->phydev->supported)) netdev->phydev->supported))
return; return;
} }
...@@ -491,7 +491,7 @@ stmmac_set_pauseparam(struct net_device *netdev, ...@@ -491,7 +491,7 @@ stmmac_set_pauseparam(struct net_device *netdev,
} else { } else {
if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT, if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
phy->supported) || phy->supported) ||
linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, !linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
phy->supported)) phy->supported))
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment