Commit 83c76f2c authored by Eric Biggers's avatar Eric Biggers Committed by Greg Kroah-Hartman

binder: check for binder_thread allocation failure in binder_poll()

commit f8898267 upstream.

If the kzalloc() in binder_get_thread() fails, binder_poll()
dereferences the resulting NULL pointer.

Fix it by returning POLLERR if the memory allocation failed.

This bug was found by syzkaller using fault injection.
Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Fixes: 457b9a6f ("Staging: android: add binder driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74d1cc27
......@@ -2622,6 +2622,8 @@ static unsigned int binder_poll(struct file *filp,
binder_lock(__func__);
thread = binder_get_thread(proc);
if (!thread)
return POLLERR;
wait_for_proc_work = thread->transaction_stack == NULL &&
list_empty(&thread->todo) && thread->return_error == BR_OK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment