Commit 8466ff24 authored by Yang Yingliang's avatar Yang Yingliang Committed by Thierry Reding

gpu: host1x: Fix potential double free if IOMMU is disabled

If context device has no IOMMU, the 'cdl->devs' is freed in
error path, but host1x_memory_context_list_init() doesn't
return an error code, so the module can be loaded successfully,
when it's unloading, the host1x_memory_context_list_free() is
called in host1x_remove(), it will cause double free. Set the
'cdl->devs' to NULL after freeing it to avoid double free.

Fixes: 8aa5bcb6 ("gpu: host1x: Add context device management code")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarMikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 791b5ece
...@@ -83,6 +83,7 @@ int host1x_memory_context_list_init(struct host1x *host1x) ...@@ -83,6 +83,7 @@ int host1x_memory_context_list_init(struct host1x *host1x)
device_del(&cdl->devs[i].dev); device_del(&cdl->devs[i].dev);
kfree(cdl->devs); kfree(cdl->devs);
cdl->devs = NULL;
cdl->len = 0; cdl->len = 0;
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment