Commit 84e99e58 authored by Casey Schaufler's avatar Casey Schaufler

Smack: slab-out-of-bounds in vsscanf

Add barrier to soob. Return -EOVERFLOW if the buffer
is exceeded.
Suggested-by: default avatarHillf Danton <hdanton@sina.com>
Reported-by: syzbot+bfdd4a2f07be52351350@syzkaller.appspotmail.com
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 092c94ae
...@@ -878,11 +878,21 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, ...@@ -878,11 +878,21 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf,
else else
rule += strlen(skp->smk_known) + 1; rule += strlen(skp->smk_known) + 1;
if (rule > data + count) {
rc = -EOVERFLOW;
goto out;
}
ret = sscanf(rule, "%d", &maplevel); ret = sscanf(rule, "%d", &maplevel);
if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL) if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL)
goto out; goto out;
rule += SMK_DIGITLEN; rule += SMK_DIGITLEN;
if (rule > data + count) {
rc = -EOVERFLOW;
goto out;
}
ret = sscanf(rule, "%d", &catlen); ret = sscanf(rule, "%d", &catlen);
if (ret != 1 || catlen > SMACK_CIPSO_MAXCATNUM) if (ret != 1 || catlen > SMACK_CIPSO_MAXCATNUM)
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment