Commit 84fa1865 authored by Ermin Sunj's avatar Ermin Sunj Committed by Heiko Stuebner

arm64: dts: rockchip: use codec as clock master on px30-ringneck-haikou

If the codec is not the clock master, the MCLK needs to be
synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that
on Haikou, causing distorted audio.

Before:

 Running an audio test script on Ringneck, 1kHz
 output sine wave is not stable and shows distortion.

After:

 10h audio test script loop failed only one time.
 That is 0.00014% failure rate.

Cc: stable@vger.kernel.org
Fixes: c484cf93 ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Signed-off-by: default avatarErmin Sunj <ermin.sunj@theobroma-systems.com>
Signed-off-by: default avatarJakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
Link: https://lore.kernel.org/r/20230907151725.198347-1-jakob.unterwurzacher@theobroma-systems.comSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 0bb80ecc
...@@ -68,15 +68,15 @@ i2s0-sound { ...@@ -68,15 +68,15 @@ i2s0-sound {
simple-audio-card,format = "i2s"; simple-audio-card,format = "i2s";
simple-audio-card,name = "Haikou,I2S-codec"; simple-audio-card,name = "Haikou,I2S-codec";
simple-audio-card,mclk-fs = <512>; simple-audio-card,mclk-fs = <512>;
simple-audio-card,frame-master = <&sgtl5000_codec>;
simple-audio-card,bitclock-master = <&sgtl5000_codec>;
simple-audio-card,codec { sgtl5000_codec: simple-audio-card,codec {
clocks = <&sgtl5000_clk>; clocks = <&sgtl5000_clk>;
sound-dai = <&sgtl5000>; sound-dai = <&sgtl5000>;
}; };
simple-audio-card,cpu { simple-audio-card,cpu {
bitclock-master;
frame-master;
sound-dai = <&i2s0_8ch>; sound-dai = <&i2s0_8ch>;
}; };
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment