Commit 869420a8 authored by Samuel Thibault's avatar Samuel Thibault Committed by Jakub Kicinski

SO_ZEROCOPY should return -EOPNOTSUPP rather than -ENOTSUPP

ENOTSUPP is documented as "should never be seen by user programs",
and thus not exposed in <errno.h>, and thus applications cannot safely
check against it (they get "Unknown error 524" as strerror). We should
rather return the well-known -EOPNOTSUPP.

This is similar to 2230a7ef ("drop_monitor: Use correct error
code") and 4a5cdc60 ("net/tls: Fix return values to avoid
ENOTSUPP"), which did not seem to cause problems.
Signed-off-by: default avatarSamuel Thibault <samuel.thibault@labri.fr>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20220307223126.djzvg44v2o2jkjsx@beginSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 964efdab
......@@ -1377,9 +1377,9 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
if (!(sk_is_tcp(sk) ||
(sk->sk_type == SOCK_DGRAM &&
sk->sk_protocol == IPPROTO_UDP)))
ret = -ENOTSUPP;
ret = -EOPNOTSUPP;
} else if (sk->sk_family != PF_RDS) {
ret = -ENOTSUPP;
ret = -EOPNOTSUPP;
}
if (!ret) {
if (val < 0 || val > 1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment