Commit 869b1fc0 authored by Marek Behún's avatar Marek Behún Committed by Arnd Bergmann

firmware: turris-mox-rwtm: Use dev_err_probe() where possible

Use dev_err_probe() where possible in the driver's .probe() method.
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20240831092050.23093-11-kabel@kernel.orgSigned-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent fbd48bd8
......@@ -459,13 +459,9 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
rwtm->mbox_client.rx_callback = mox_rwtm_rx_callback;
rwtm->mbox = mbox_request_channel(&rwtm->mbox_client, 0);
if (IS_ERR(rwtm->mbox)) {
ret = PTR_ERR(rwtm->mbox);
if (ret != -EPROBE_DEFER)
dev_err(dev, "Cannot request mailbox channel: %i\n",
ret);
return ret;
}
if (IS_ERR(rwtm->mbox))
return dev_err_probe(dev, PTR_ERR(rwtm->mbox),
"Cannot request mailbox channel!\n");
ret = devm_add_action_or_reset(dev, rwtm_devm_mbox_release, rwtm->mbox);
if (ret)
......@@ -487,10 +483,8 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
rwtm->hwrng.priv = (unsigned long) rwtm;
ret = devm_hwrng_register(dev, &rwtm->hwrng);
if (ret < 0) {
dev_err(dev, "Cannot register HWRNG: %i\n", ret);
return ret;
}
if (ret)
return dev_err_probe(dev, ret, "Cannot register HWRNG!\n");
rwtm_register_debugfs(rwtm);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment