Commit 86f3daed authored by Laurent Pinchart's avatar Laurent Pinchart

usb: gadget: uvc: configfs: Drop leaked references to config items

Some of the .allow_link() and .drop_link() operations implementations
call config_group_find_item() and then leak the reference to the
returned item. Fix this by dropping those references where needed.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
parent f7d8109e
...@@ -529,6 +529,7 @@ static int uvcg_control_class_allow_link(struct config_item *src, ...@@ -529,6 +529,7 @@ static int uvcg_control_class_allow_link(struct config_item *src,
unlock: unlock:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
out: out:
config_item_put(header);
mutex_unlock(su_mutex); mutex_unlock(su_mutex);
return ret; return ret;
} }
...@@ -564,6 +565,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, ...@@ -564,6 +565,7 @@ static void uvcg_control_class_drop_link(struct config_item *src,
unlock: unlock:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
out: out:
config_item_put(header);
mutex_unlock(su_mutex); mutex_unlock(su_mutex);
} }
...@@ -2026,6 +2028,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src, ...@@ -2026,6 +2028,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src,
unlock: unlock:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
out: out:
config_item_put(header);
mutex_unlock(su_mutex); mutex_unlock(su_mutex);
return ret; return ret;
} }
...@@ -2066,6 +2069,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, ...@@ -2066,6 +2069,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src,
unlock: unlock:
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
out: out:
config_item_put(header);
mutex_unlock(su_mutex); mutex_unlock(su_mutex);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment