Commit 885e7b0e authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger

target: Don't call TFO->write_pending if data_length == 0

If an initiator sends a zero-length command (e.g. TEST UNIT READY) but
sets the transfer direction in the transport layer to indicate a
data-out phase, we still shouldn't try to transfer data.  At best it's
a NOP, and depending on the transport, we might crash on an
uninitialized sg list.
Reported-by: default avatarCraig Watson <craig.watson@vanguard-rugged.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Cc: <stable@vger.kernel.org> # 3.1
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent cac7f242
...@@ -2292,7 +2292,7 @@ transport_generic_new_cmd(struct se_cmd *cmd) ...@@ -2292,7 +2292,7 @@ transport_generic_new_cmd(struct se_cmd *cmd)
* and let it call back once the write buffers are ready. * and let it call back once the write buffers are ready.
*/ */
target_add_to_state_list(cmd); target_add_to_state_list(cmd);
if (cmd->data_direction != DMA_TO_DEVICE) { if (cmd->data_direction != DMA_TO_DEVICE || cmd->data_length == 0) {
target_execute_cmd(cmd); target_execute_cmd(cmd);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment