Commit 88a5045f authored by Evan Green's avatar Evan Green Committed by Rafael J. Wysocki

PM: hibernate: Fix snapshot partial write lengths

snapshot_write() is inappropriately limiting the amount of data that can
be written in cases where a partial page has already been written. For
example, one would expect to be able to write 1 byte, then 4095 bytes to
the snapshot device, and have both of those complete fully (since now
we're aligned to a page again). But what ends up happening is we write 1
byte, then 4094/4095 bytes complete successfully.

The reason is that simple_write_to_buffer()'s second argument is the
total size of the buffer, not the size of the buffer minus the offset.
Since simple_write_to_buffer() accounts for the offset in its
implementation, snapshot_write() can just pass the full page size
directly down.
Signed-off-by: default avatarEvan Green <evgreen@chromium.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cefcf24b
...@@ -177,7 +177,7 @@ static ssize_t snapshot_write(struct file *filp, const char __user *buf, ...@@ -177,7 +177,7 @@ static ssize_t snapshot_write(struct file *filp, const char __user *buf,
if (res <= 0) if (res <= 0)
goto unlock; goto unlock;
} else { } else {
res = PAGE_SIZE - pg_offp; res = PAGE_SIZE;
} }
if (!data_of(data->handle)) { if (!data_of(data->handle)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment