Commit 88b37c3a authored by Deepak Rawat's avatar Deepak Rawat Committed by Thomas Hellstrom

drm/vmwgfx: Update comments for stdu plane update

Update the comments to sync with code.
Signed-off-by: default avatarDeepak Rawat <drawat@vmware.com>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
parent 4606eeaf
...@@ -1656,7 +1656,6 @@ static int vmw_stdu_plane_update_surface(struct vmw_private *dev_priv, ...@@ -1656,7 +1656,6 @@ static int vmw_stdu_plane_update_surface(struct vmw_private *dev_priv,
/** /**
* vmw_stdu_primary_plane_atomic_update - formally switches STDU to new plane * vmw_stdu_primary_plane_atomic_update - formally switches STDU to new plane
*
* @plane: display plane * @plane: display plane
* @old_state: Only used to get crtc info * @old_state: Only used to get crtc info
* *
...@@ -1677,10 +1676,7 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane, ...@@ -1677,10 +1676,7 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane,
struct vmw_private *dev_priv; struct vmw_private *dev_priv;
int ret; int ret;
/* /* If case of device error, maintain consistent atomic state */
* We cannot really fail this function, so if we do, then output an
* error and maintain consistent atomic state.
*/
if (crtc && plane->state->fb) { if (crtc && plane->state->fb) {
struct vmw_framebuffer *vfb = struct vmw_framebuffer *vfb =
vmw_framebuffer_to_vfb(plane->state->fb); vmw_framebuffer_to_vfb(plane->state->fb);
...@@ -1709,12 +1705,7 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane, ...@@ -1709,12 +1705,7 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane,
stdu = vmw_crtc_to_stdu(crtc); stdu = vmw_crtc_to_stdu(crtc);
dev_priv = vmw_priv(crtc->dev); dev_priv = vmw_priv(crtc->dev);
/* /* Blank STDU when fb and crtc are NULL */
* When disabling a plane, CRTC and FB should always be NULL
* together, otherwise it's an error.
* Here primary plane is being disable so blank the screen
* target display unit, if not already done.
*/
if (!stdu->defined) if (!stdu->defined)
return; return;
...@@ -1729,11 +1720,8 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane, ...@@ -1729,11 +1720,8 @@ vmw_stdu_primary_plane_atomic_update(struct drm_plane *plane,
return; return;
} }
/* In case of error, vblank event is send in vmw_du_crtc_atomic_flush */
event = crtc->state->event; event = crtc->state->event;
/*
* In case of failure and other cases, vblank event will be sent in
* vmw_du_crtc_atomic_flush.
*/
if (event && fence) { if (event && fence) {
struct drm_file *file_priv = event->base.file_priv; struct drm_file *file_priv = event->base.file_priv;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment