Commit 88fc023f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller

net: socket: return changed ifreq from SIOCDEVPRIVATE

Some drivers that use SIOCDEVPRIVATE ioctl commands modify
the ifreq structure and expect it to be passed back to user
space, which has never really happened for compat mode
because the calling these drivers through ndo_do_ioctl
requires overwriting the ifr_data pointer.

Now that all drivers are converted to ndo_siocdevprivate,
change it to handle this correctly in both compat and
native mode.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad7eab2a
...@@ -286,9 +286,7 @@ static int dev_siocdevprivate(struct net_device *dev, struct ifreq *ifr, ...@@ -286,9 +286,7 @@ static int dev_siocdevprivate(struct net_device *dev, struct ifreq *ifr,
return -ENODEV; return -ENODEV;
} }
/* fall back to do_ioctl for drivers not yet converted */ return -EOPNOTSUPP;
ifr->ifr_data = data;
return dev_do_ioctl(dev, ifr, cmd);
} }
static int dev_siocwandev(struct net_device *dev, struct if_settings *ifs) static int dev_siocwandev(struct net_device *dev, struct if_settings *ifs)
......
...@@ -3234,7 +3234,7 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock, ...@@ -3234,7 +3234,7 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock,
struct net *net = sock_net(sk); struct net *net = sock_net(sk);
if (cmd >= SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE + 15)) if (cmd >= SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE + 15))
return compat_ifr_data_ioctl(net, cmd, argp); return sock_ioctl(file, cmd, (unsigned long)argp);
switch (cmd) { switch (cmd) {
case SIOCSIFBR: case SIOCSIFBR:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment