Commit 8aae2b1c authored by Ville Syrjälä's avatar Ville Syrjälä

drm/i915: Pick the first unused PLL once again

commit 5b0bd14d ("drm/i915/icl: keep track of unused pll while
looping") inadvertently (I presume) changed the code to pick the
last unused dpll rather than the first unused one like we did before.

While there should most likely be no harm in changing the order
let's change back just to avoid a change in the behaviour. At
least it might reduce the confusion when staring at logs (took
me a while to figure out why DPLL1 being picked over DPLL0
when the latter was most definitely available).

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190130181359.20693-1-ville.syrjala@linux.intel.comReviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Acked-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent ad3e7b82
...@@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc, ...@@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc,
/* Only want to check enabled timings first */ /* Only want to check enabled timings first */
if (shared_dpll[i].crtc_mask == 0) { if (shared_dpll[i].crtc_mask == 0) {
unused_pll = pll; if (!unused_pll)
unused_pll = pll;
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment