Commit 8b57b11b authored by Flavio Suligoi's avatar Flavio Suligoi Committed by Mark Brown

spi: pxa2xxx: change "no DMA channels..." msg from debug to warning

Change the type of the diagnostic message:

"no DMA channels available, using PIO"

from debug to warning.

The lack of an available DMA channel is very important regard the
spi-pxa2xx performance. The transfer speed can be reduced more than 50%.

So it is very important to warn the user about this, without enabling
the full SPI debug with CONFIG_SPI_DEBUG.

Moreover, enabling the full SPI debug only to enable this specific
debug message, the dmesg buffer fills quickly with a lot of
repetitive information during the SPI data transfer.
This cause the loss of all the first important messages
written during the initialization.
Signed-off-by: default avatarFlavio Suligoi <f.suligoi@asem.it>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5d785141
...@@ -1696,7 +1696,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) ...@@ -1696,7 +1696,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
if (platform_info->enable_dma) { if (platform_info->enable_dma) {
status = pxa2xx_spi_dma_setup(drv_data); status = pxa2xx_spi_dma_setup(drv_data);
if (status) { if (status) {
dev_dbg(dev, "no DMA channels available, using PIO\n"); dev_warn(dev, "no DMA channels available, using PIO\n");
platform_info->enable_dma = false; platform_info->enable_dma = false;
} else { } else {
controller->can_dma = pxa2xx_spi_can_dma; controller->can_dma = pxa2xx_spi_can_dma;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment