Commit 8c0614ca authored by Wei Yongjun's avatar Wei Yongjun Committed by Peter Chen

usb: chipidea: fix return value check in ci_hdrc_pci_probe()

In case of error, the function usb_phy_generic_register()
returns ERR_PTR() and never returns NULL. The NULL test in
the return value check should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarPeter Chen <peter.chen@nxp.com>
parent a4de018d
...@@ -85,8 +85,8 @@ static int ci_hdrc_pci_probe(struct pci_dev *pdev, ...@@ -85,8 +85,8 @@ static int ci_hdrc_pci_probe(struct pci_dev *pdev,
/* register a nop PHY */ /* register a nop PHY */
ci->phy = usb_phy_generic_register(); ci->phy = usb_phy_generic_register();
if (!ci->phy) if (IS_ERR(ci->phy))
return -ENOMEM; return PTR_ERR(ci->phy);
memset(res, 0, sizeof(res)); memset(res, 0, sizeof(res));
res[0].start = pci_resource_start(pdev, 0); res[0].start = pci_resource_start(pdev, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment