Commit 8cbde6c6 authored by Tianjia Zhang's avatar Tianjia Zhang Committed by Herbert Xu

crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

In case of memory allocation failure, a negative error code should
be returned.

Fixes: 785e5c61 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e62291c1
...@@ -442,7 +442,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp) ...@@ -442,7 +442,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp)
static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
{ {
struct mtk_ring **ring = cryp->ring; struct mtk_ring **ring = cryp->ring;
int i, err = ENOMEM; int i;
for (i = 0; i < MTK_RING_MAX; i++) { for (i = 0; i < MTK_RING_MAX; i++) {
ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL); ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL);
...@@ -476,7 +476,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) ...@@ -476,7 +476,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
ring[i]->cmd_base, ring[i]->cmd_dma); ring[i]->cmd_base, ring[i]->cmd_dma);
kfree(ring[i]); kfree(ring[i]);
} }
return err; return -ENOMEM;
} }
static int mtk_crypto_probe(struct platform_device *pdev) static int mtk_crypto_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment