Commit 8e4052c3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski

net: dsa: b53: fix an off by one in checking "vlan->vid"

The > comparison should be >= to prevent accessing one element beyond
the end of the dev->vlans[] array in the caller function, b53_vlan_add().
The "dev->vlans" array is allocated in the b53_switch_init() function
and it has "dev->num_vlans" elements.

Fixes: a2482d2c ("net: dsa: b53: Plug in VLAN support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/YAbxI97Dl/pmBy5V@mwandaSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b160c285
...@@ -1404,7 +1404,7 @@ int b53_vlan_prepare(struct dsa_switch *ds, int port, ...@@ -1404,7 +1404,7 @@ int b53_vlan_prepare(struct dsa_switch *ds, int port,
!(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED)) !(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED))
return -EINVAL; return -EINVAL;
if (vlan->vid_end > dev->num_vlans) if (vlan->vid_end >= dev->num_vlans)
return -ERANGE; return -ERANGE;
b53_enable_vlan(dev, true, ds->vlan_filtering); b53_enable_vlan(dev, true, ds->vlan_filtering);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment