Commit 8e5debed authored by Wong Vee Khee's avatar Wong Vee Khee Committed by Jakub Kicinski

net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call

Fix an issue where dump stack is printed on suspend resume flow due to
netif_set_real_num_rx_queues() is not called with rtnl_lock held().

Fixes: 686cff3d ("net: stmmac: Fix incorrect location to set real_num_rx|tx_queues")
Reported-by: default avatarChristophe ROULLIER <christophe.roullier@st.com>
Tested-by: default avatarChristophe ROULLIER <christophe.roullier@st.com>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>
Reviewed-by: default avatarOng Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@intel.com>
Link: https://lore.kernel.org/r/20201115074210.23605-1-vee.khee.wong@intel.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7a30ecc9
......@@ -5247,6 +5247,7 @@ int stmmac_resume(struct device *dev)
return ret;
}
rtnl_lock();
mutex_lock(&priv->lock);
stmmac_reset_queues_param(priv);
......@@ -5262,6 +5263,7 @@ int stmmac_resume(struct device *dev)
stmmac_enable_all_queues(priv);
mutex_unlock(&priv->lock);
rtnl_unlock();
if (!device_may_wakeup(priv->device) || !priv->plat->pmt) {
rtnl_lock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment