Commit 90732f17 authored by Dongliang Mu's avatar Dongliang Mu Committed by Greg Kroah-Hartman

usb: cdns3: adjust the partial logic of cdnsp_pci_remove

In cdnsp_pci_remove, if pci_is_enabled returns true, it will
call cdns_remove; else it will call kfree. Then both control flow
goes to pci_dev_put.

Adjust this logic by modifying it to an if else.
Signed-off-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Acked-by: default avatarPawel Laszczak <pawell@cadence.com>
Link: https://lore.kernel.org/r/20221009072305.1593707-1-dzm91@hust.edu.cnSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 27ef01e3
...@@ -192,14 +192,12 @@ static void cdnsp_pci_remove(struct pci_dev *pdev) ...@@ -192,14 +192,12 @@ static void cdnsp_pci_remove(struct pci_dev *pdev)
if (pci_dev_run_wake(pdev)) if (pci_dev_run_wake(pdev))
pm_runtime_get_noresume(&pdev->dev); pm_runtime_get_noresume(&pdev->dev);
if (!pci_is_enabled(func)) { if (pci_is_enabled(func)) {
cdns_remove(cdnsp);
} else {
kfree(cdnsp); kfree(cdnsp);
goto pci_put;
} }
cdns_remove(cdnsp);
pci_put:
pci_dev_put(func); pci_dev_put(func);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment