Commit 915f1d23 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by Vinod Koul

phy: phy-brcm-usb: specify init function format at struct level

This is slightly cleaner solution that assures noone assings a wrong
function to the pointer.
Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201216143305.12179-2-zajec5@gmail.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent d14f4cce
...@@ -35,7 +35,7 @@ struct value_to_name_map { ...@@ -35,7 +35,7 @@ struct value_to_name_map {
}; };
struct match_chip_info { struct match_chip_info {
void *init_func; void (*init_func)(struct brcm_usb_init_params *params);
u8 required_regs[BRCM_REGS_MAX + 1]; u8 required_regs[BRCM_REGS_MAX + 1];
u8 optional_reg; u8 optional_reg;
}; };
...@@ -428,7 +428,6 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) ...@@ -428,7 +428,6 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
struct device_node *dn = pdev->dev.of_node; struct device_node *dn = pdev->dev.of_node;
int err; int err;
const char *mode; const char *mode;
void (*dvr_init)(struct brcm_usb_init_params *params);
const struct match_chip_info *info; const struct match_chip_info *info;
struct regmap *rmap; struct regmap *rmap;
int x; int x;
...@@ -444,8 +443,8 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) ...@@ -444,8 +443,8 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
info = of_device_get_match_data(&pdev->dev); info = of_device_get_match_data(&pdev->dev);
if (!info) if (!info)
return -ENOENT; return -ENOENT;
dvr_init = info->init_func;
(*dvr_init)(&priv->ini); info->init_func(&priv->ini);
dev_dbg(dev, "Best mapping table is for %s\n", dev_dbg(dev, "Best mapping table is for %s\n",
priv->ini.family_name); priv->ini.family_name);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment