Commit 917a3200 authored by Dinghao Liu's avatar Dinghao Liu Committed by Vinod Koul

dmaengine: tegra20: Fix runtime PM imbalance on error

pm_runtime_get_sync() will increase the runtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20210409082805.23643-1-dinghao.liu@zju.edu.cnSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent ea45b600
...@@ -723,7 +723,7 @@ static void tegra_dma_issue_pending(struct dma_chan *dc) ...@@ -723,7 +723,7 @@ static void tegra_dma_issue_pending(struct dma_chan *dc)
goto end; goto end;
} }
if (!tdc->busy) { if (!tdc->busy) {
err = pm_runtime_get_sync(tdc->tdma->dev); err = pm_runtime_resume_and_get(tdc->tdma->dev);
if (err < 0) { if (err < 0) {
dev_err(tdc2dev(tdc), "Failed to enable DMA\n"); dev_err(tdc2dev(tdc), "Failed to enable DMA\n");
goto end; goto end;
...@@ -818,7 +818,7 @@ static void tegra_dma_synchronize(struct dma_chan *dc) ...@@ -818,7 +818,7 @@ static void tegra_dma_synchronize(struct dma_chan *dc)
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc); struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
int err; int err;
err = pm_runtime_get_sync(tdc->tdma->dev); err = pm_runtime_resume_and_get(tdc->tdma->dev);
if (err < 0) { if (err < 0) {
dev_err(tdc2dev(tdc), "Failed to synchronize DMA: %d\n", err); dev_err(tdc2dev(tdc), "Failed to synchronize DMA: %d\n", err);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment