Commit 92123e06 authored by Jeff Layton's avatar Jeff Layton Committed by Trond Myklebust

rpc_pipefs: allow rpc_purge_list to take a NULL waitq pointer

In the event that we don't have a dentry for a rpc_pipefs pipe, we still
need to allow the queue_timeout job to clean out the queue. There's just
no waitq to wake up in that event.

Cc: stable@kernel.org
Reported-by: default avatarHans de Bruin <jmdebruin@xmsnet.nl>
Reported-by: default avatarJoerg Platte <jplatte@naasa.net>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 2669940d
...@@ -71,7 +71,9 @@ static void rpc_purge_list(wait_queue_head_t *waitq, struct list_head *head, ...@@ -71,7 +71,9 @@ static void rpc_purge_list(wait_queue_head_t *waitq, struct list_head *head,
msg->errno = err; msg->errno = err;
destroy_msg(msg); destroy_msg(msg);
} while (!list_empty(head)); } while (!list_empty(head));
wake_up(waitq);
if (waitq)
wake_up(waitq);
} }
static void static void
...@@ -91,11 +93,9 @@ rpc_timeout_upcall_queue(struct work_struct *work) ...@@ -91,11 +93,9 @@ rpc_timeout_upcall_queue(struct work_struct *work)
} }
dentry = dget(pipe->dentry); dentry = dget(pipe->dentry);
spin_unlock(&pipe->lock); spin_unlock(&pipe->lock);
if (dentry) { rpc_purge_list(dentry ? &RPC_I(dentry->d_inode)->waitq : NULL,
rpc_purge_list(&RPC_I(dentry->d_inode)->waitq, &free_list, destroy_msg, -ETIMEDOUT);
&free_list, destroy_msg, -ETIMEDOUT); dput(dentry);
dput(dentry);
}
} }
ssize_t rpc_pipe_generic_upcall(struct file *filp, struct rpc_pipe_msg *msg, ssize_t rpc_pipe_generic_upcall(struct file *filp, struct rpc_pipe_msg *msg,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment