Commit 92d9d61b authored by Ganesh Goudar's avatar Ganesh Goudar Committed by Michael Ellerman

powerpc/mce: save ignore_event flag unconditionally for UE

When we hit an UE while using machine check safe copy routines,
ignore_event flag is set and the event is ignored by mce handler,
And the flag is also saved for defered handling and printing of
mce event information, But as of now saving of this flag is done
on checking if the effective address is provided or physical address
is calculated, which is not right.

Save ignore_event flag regardless of whether the effective address is
provided or physical address is calculated.

Without this change following log is seen, when the event is to be
ignored.

[  512.971365] MCE: CPU1: machine check (Severe)  UE Load/Store [Recovered]
[  512.971509] MCE: CPU1: NIP: [c0000000000b67c0] memcpy+0x40/0x90
[  512.971655] MCE: CPU1: Initiator CPU
[  512.971739] MCE: CPU1: Unknown
[  512.972209] MCE: CPU1: machine check (Severe)  UE Load/Store [Recovered]
[  512.972334] MCE: CPU1: NIP: [c0000000000b6808] memcpy+0x88/0x90
[  512.972456] MCE: CPU1: Initiator CPU
[  512.972534] MCE: CPU1: Unknown
Signed-off-by: default avatarGanesh Goudar <ganeshgr@linux.ibm.com>
Reviewed-by: default avatarSantosh Sivaraj <santosh@fossix.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210407045816.352276-1-ganeshgr@linux.ibm.com
parent eacf4c02
...@@ -131,6 +131,8 @@ void save_mce_event(struct pt_regs *regs, long handled, ...@@ -131,6 +131,8 @@ void save_mce_event(struct pt_regs *regs, long handled,
* Populate the mce error_type and type-specific error_type. * Populate the mce error_type and type-specific error_type.
*/ */
mce_set_error_info(mce, mce_err); mce_set_error_info(mce, mce_err);
if (mce->error_type == MCE_ERROR_TYPE_UE)
mce->u.ue_error.ignore_event = mce_err->ignore_event;
if (!addr) if (!addr)
return; return;
...@@ -159,7 +161,6 @@ void save_mce_event(struct pt_regs *regs, long handled, ...@@ -159,7 +161,6 @@ void save_mce_event(struct pt_regs *regs, long handled,
if (phys_addr != ULONG_MAX) { if (phys_addr != ULONG_MAX) {
mce->u.ue_error.physical_address_provided = true; mce->u.ue_error.physical_address_provided = true;
mce->u.ue_error.physical_address = phys_addr; mce->u.ue_error.physical_address = phys_addr;
mce->u.ue_error.ignore_event = mce_err->ignore_event;
machine_check_ue_event(mce); machine_check_ue_event(mce);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment