Commit 935603e8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thomas Gleixner

irqchip/stm32-exti: Convert to platform_driver::remove_new() callback

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarAntonio Borneo <antonio.borneo@foss.st.com>
Link: https://lore.kernel.org/r/ac551b89025bafadce05102b94596f8cd3564a32.1703284359.git.u.kleine-koenig@pengutronix.de
parent d1c762d9
...@@ -898,10 +898,9 @@ static void stm32_exti_remove_irq(void *data) ...@@ -898,10 +898,9 @@ static void stm32_exti_remove_irq(void *data)
irq_domain_remove(domain); irq_domain_remove(domain);
} }
static int stm32_exti_remove(struct platform_device *pdev) static void stm32_exti_remove(struct platform_device *pdev)
{ {
stm32_exti_h_syscore_deinit(); stm32_exti_h_syscore_deinit();
return 0;
} }
static int stm32_exti_probe(struct platform_device *pdev) static int stm32_exti_probe(struct platform_device *pdev)
...@@ -991,10 +990,10 @@ MODULE_DEVICE_TABLE(of, stm32_exti_ids); ...@@ -991,10 +990,10 @@ MODULE_DEVICE_TABLE(of, stm32_exti_ids);
static struct platform_driver stm32_exti_driver = { static struct platform_driver stm32_exti_driver = {
.probe = stm32_exti_probe, .probe = stm32_exti_probe,
.remove = stm32_exti_remove, .remove_new = stm32_exti_remove,
.driver = { .driver = {
.name = "stm32_exti", .name = "stm32_exti",
.of_match_table = stm32_exti_ids, .of_match_table = stm32_exti_ids,
}, },
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment