Commit 93ccfa9a authored by Daniel Vetter's avatar Daniel Vetter

drm/todo: Updating logging todo

Jani has merged a new set of logging functions, which we hope to be
the One True solution now, pinky promises:

commit fb6c7ab8
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Tue Dec 10 14:30:43 2019 +0200

    drm/print: introduce new struct drm_device based logging macros

Update the todo entry to match the new preference.

v2: Fix spelling issue Sam noticed.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191219161722.2779994-1-daniel.vetter@ffwll.ch
parent 7da54927
...@@ -142,14 +142,14 @@ Contact: Daniel Vetter, respective driver maintainers ...@@ -142,14 +142,14 @@ Contact: Daniel Vetter, respective driver maintainers
Level: Advanced Level: Advanced
Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent Convert logging to drm_* functions with drm_device paramater
---------------------------------------------------------------------------- ------------------------------------------------------------
For drivers which could have multiple instances, it is necessary to For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR
don't do this, drivers used dev_info/warn/err to make this differentiation. We don't do this, drivers used dev_info/warn/err to make this differentiation. We
now have DRM_DEV_* variants of the drm print macros, so we can start to convert now have drm_* variants of the drm print functions, so we can start to convert
those drivers back to using drm-formwatted specific log messages. those drivers back to using drm-formatted specific log messages.
Before you start this conversion please contact the relevant maintainers to make Before you start this conversion please contact the relevant maintainers to make
sure your work will be merged - not everyone agrees that the DRM dmesg macros sure your work will be merged - not everyone agrees that the DRM dmesg macros
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment