Commit 94945ad2 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso

netfilter: conntrack: comparison of unsigned in cthelper confirmation

net/netfilter/nf_conntrack_core.c: In function nf_confirm_cthelper:
net/netfilter/nf_conntrack_core.c:2117:15: warning: comparison of unsigned expression in < 0 is always false [-Wtype-limits]
 2117 |   if (protoff < 0 || (frag_off & htons(~0x7)) != 0)
      |               ^

ipv6_skip_exthdr() returns a signed integer.
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Fixes: 703acd70 ("netfilter: nfnetlink_cthelper: unbreak userspace helper support")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 46c1e062
...@@ -2092,7 +2092,7 @@ static int nf_confirm_cthelper(struct sk_buff *skb, struct nf_conn *ct, ...@@ -2092,7 +2092,7 @@ static int nf_confirm_cthelper(struct sk_buff *skb, struct nf_conn *ct,
{ {
const struct nf_conntrack_helper *helper; const struct nf_conntrack_helper *helper;
const struct nf_conn_help *help; const struct nf_conn_help *help;
unsigned int protoff; int protoff;
help = nfct_help(ct); help = nfct_help(ct);
if (!help) if (!help)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment