Commit 95ca19cf authored by Sedat Dilek's avatar Sedat Dilek Committed by Dave Airlie

drm: udl: usb: Fix recursive Kconfig dependency

In drivers/usb/Kconfig "config USB_ARCH_HAS_HCD" is within "if USB_SUPPORT"
statement.

In drivers/gpu/drm/Kconfig "config DRM_USB" depends on USB_ARCH_HAS_HCD
but selects USB_SUPPORT which leads to the error for udl Kconfig:

$ yes "" | make oldconfig
scripts/kconfig/conf --oldconfig Kconfig
drivers/gpu/drm/udl/Kconfig:1:error: recursive dependency detected!
drivers/gpu/drm/udl/Kconfig:1:  symbol DRM_UDL depends on USB_ARCH_HAS_HCD
drivers/usb/Kconfig:76: symbol USB_ARCH_HAS_HCD depends on USB_SUPPORT
drivers/usb/Kconfig:58: symbol USB_SUPPORT is selected by DRM_USB
drivers/gpu/drm/Kconfig:22:     symbol DRM_USB is selected by DRM_UDL

Fix this by changing from select to depends on USB_SUPPORT in
"config DRM_USB".

This is a follow-up fix to df0b3443
in Dave's drm-next GIT branch.

[ v2: Restore old status, but change from select to depends on USB_SUPPORT ]
Signed-off-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@gmail.com>
parent 85f9e50d
...@@ -22,9 +22,8 @@ menuconfig DRM ...@@ -22,9 +22,8 @@ menuconfig DRM
config DRM_USB config DRM_USB
tristate tristate
depends on DRM depends on DRM
depends on USB_ARCH_HAS_HCD depends on USB_SUPPORT && USB_ARCH_HAS_HCD
select USB select USB
select USB_SUPPORT
config DRM_KMS_HELPER config DRM_KMS_HELPER
tristate tristate
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment