Commit 96273f43 authored by Peter Meerwald-Stadler's avatar Peter Meerwald-Stadler Committed by Jonathan Cameron

staging: iio: isl29018: Cleanup of comments

Signed-off-by: default avatarPeter Meerwald-Stadler <pmeerw@pmeerw.net>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent c833c692
...@@ -133,7 +133,7 @@ static int isl29018_set_integration_time(struct isl29018_chip *chip, ...@@ -133,7 +133,7 @@ static int isl29018_set_integration_time(struct isl29018_chip *chip,
if (ret < 0) if (ret < 0)
return ret; return ret;
/* keep the same range when integration time changes */ /* Keep the same range when integration time changes */
int_time = chip->int_time; int_time = chip->int_time;
for (i = 0; i < ARRAY_SIZE(isl29018_scales[int_time]); ++i) { for (i = 0; i < ARRAY_SIZE(isl29018_scales[int_time]); ++i) {
if (chip->scale.scale == isl29018_scales[int_time][i].scale && if (chip->scale.scale == isl29018_scales[int_time][i].scale &&
...@@ -313,7 +313,6 @@ static ssize_t show_int_time_available(struct device *dev, ...@@ -313,7 +313,6 @@ static ssize_t show_int_time_available(struct device *dev,
return len; return len;
} }
/* proximity scheme */
static ssize_t show_prox_infrared_suppression(struct device *dev, static ssize_t show_prox_infrared_suppression(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
...@@ -322,7 +321,7 @@ static ssize_t show_prox_infrared_suppression(struct device *dev, ...@@ -322,7 +321,7 @@ static ssize_t show_prox_infrared_suppression(struct device *dev,
struct isl29018_chip *chip = iio_priv(indio_dev); struct isl29018_chip *chip = iio_priv(indio_dev);
/* /*
* return the "proximity scheme" i.e. if the chip does on chip * Return the "proximity scheme" i.e. if the chip does on chip
* infrared suppression (1 means perform on chip suppression) * infrared suppression (1 means perform on chip suppression)
*/ */
return sprintf(buf, "%d\n", chip->prox_scheme); return sprintf(buf, "%d\n", chip->prox_scheme);
...@@ -342,7 +341,7 @@ static ssize_t store_prox_infrared_suppression(struct device *dev, ...@@ -342,7 +341,7 @@ static ssize_t store_prox_infrared_suppression(struct device *dev,
return -EINVAL; return -EINVAL;
/* /*
* get the "proximity scheme" i.e. if the chip does on chip * Get the "proximity scheme" i.e. if the chip does on chip
* infrared suppression (1 means perform on chip suppression) * infrared suppression (1 means perform on chip suppression)
*/ */
mutex_lock(&chip->lock); mutex_lock(&chip->lock);
...@@ -352,7 +351,6 @@ static ssize_t store_prox_infrared_suppression(struct device *dev, ...@@ -352,7 +351,6 @@ static ssize_t store_prox_infrared_suppression(struct device *dev,
return count; return count;
} }
/* Channel IO */
static int isl29018_write_raw(struct iio_dev *indio_dev, static int isl29018_write_raw(struct iio_dev *indio_dev,
struct iio_chan_spec const *chan, struct iio_chan_spec const *chan,
int val, int val,
...@@ -539,7 +537,7 @@ static int isl29035_detect(struct isl29018_chip *chip) ...@@ -539,7 +537,7 @@ static int isl29035_detect(struct isl29018_chip *chip)
if (id != ISL29035_DEVICE_ID) if (id != ISL29035_DEVICE_ID)
return -ENODEV; return -ENODEV;
/* clear out brownout bit */ /* Clear brownout bit */
return regmap_update_bits(chip->regmap, ISL29035_REG_DEVICE_ID, return regmap_update_bits(chip->regmap, ISL29035_REG_DEVICE_ID,
ISL29035_BOUT_MASK, 0); ISL29035_BOUT_MASK, 0);
} }
...@@ -572,7 +570,7 @@ static int isl29018_chip_init(struct isl29018_chip *chip) ...@@ -572,7 +570,7 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
* conversions, clear the test registers, and then rewrite all * conversions, clear the test registers, and then rewrite all
* registers to the desired values. * registers to the desired values.
* ... * ...
* FOR ISL29011, ISL29018, ISL29021, ISL29023 * For ISL29011, ISL29018, ISL29021, ISL29023
* 1. Write 0x00 to register 0x08 (TEST) * 1. Write 0x00 to register 0x08 (TEST)
* 2. Write 0x00 to register 0x00 (CMD1) * 2. Write 0x00 to register 0x00 (CMD1)
* 3. Rewrite all registers to the desired values * 3. Rewrite all registers to the desired values
...@@ -601,7 +599,7 @@ static int isl29018_chip_init(struct isl29018_chip *chip) ...@@ -601,7 +599,7 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
usleep_range(1000, 2000); /* per data sheet, page 10 */ usleep_range(1000, 2000); /* per data sheet, page 10 */
/* set defaults */ /* Set defaults */
status = isl29018_set_scale(chip, chip->scale.scale, status = isl29018_set_scale(chip, chip->scale.scale,
chip->scale.uscale); chip->scale.uscale);
if (status < 0) { if (status < 0) {
...@@ -647,10 +645,6 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg) ...@@ -647,10 +645,6 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg)
} }
} }
/*
* isl29018_regmap_config: regmap configuration.
* Use RBTREE mechanism for caching.
*/
static const struct regmap_config isl29018_regmap_config = { static const struct regmap_config isl29018_regmap_config = {
.reg_bits = 8, .reg_bits = 8,
.val_bits = 8, .val_bits = 8,
...@@ -660,7 +654,6 @@ static const struct regmap_config isl29018_regmap_config = { ...@@ -660,7 +654,6 @@ static const struct regmap_config isl29018_regmap_config = {
.cache_type = REGCACHE_RBTREE, .cache_type = REGCACHE_RBTREE,
}; };
/* isl29035_regmap_config: regmap configuration for ISL29035 */
static const struct regmap_config isl29035_regmap_config = { static const struct regmap_config isl29035_regmap_config = {
.reg_bits = 8, .reg_bits = 8,
.val_bits = 8, .val_bits = 8,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment