Commit 9665eaf5 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman

staging: vt6655: Convert macro MACvReceive0 to function

Convert macro to static function. Multiline macros are not liked by
kernel community. Rename variable dwData to reg_value to avoid
CamelCase which is not accepted by checkpatch.pl. Change variable
declaration to u32 as this improves readability.
Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/059aca149bd0c1d75df4fb3cd8a177aa4948fb02.1659080988.git.philipp.g.hortmann@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 568035b0
...@@ -205,6 +205,17 @@ static void vt6655_mac_read_ether_addr(void __iomem *iobase, u8 *mac_addr) ...@@ -205,6 +205,17 @@ static void vt6655_mac_read_ether_addr(void __iomem *iobase, u8 *mac_addr)
iowrite8(0, iobase + MAC_REG_PAGE1SEL); iowrite8(0, iobase + MAC_REG_PAGE1SEL);
} }
static void MACvReceive0(void __iomem *iobase)
{
u32 reg_value;
reg_value = ioread32(iobase + MAC_REG_RXDMACTL0);
if (reg_value & DMACTL_RUN)
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL0);
else
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL0);
}
/* /*
* Initialisation of MAC & BBP registers * Initialisation of MAC & BBP registers
*/ */
......
...@@ -537,16 +537,6 @@ ...@@ -537,16 +537,6 @@
/*--------------------- Export Macros ------------------------------*/ /*--------------------- Export Macros ------------------------------*/
#define MACvReceive0(iobase) \
do { \
unsigned long dwData; \
dwData = ioread32(iobase + MAC_REG_RXDMACTL0); \
if (dwData & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL0); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL0); \
} while (0)
#define MACvReceive1(iobase) \ #define MACvReceive1(iobase) \
do { \ do { \
unsigned long dwData; \ unsigned long dwData; \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment