Commit 96962178 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jacek Anaszewski

leds: lp3952: Remove ACPI support for lp3952

In ACPI world any ID should be carefully chosen and registered
officially. The discussion [1] as I read it gets to wilful assignment
an ID for non-existing real DSDT example.

Rafael already told [2] how this device would be enumerated using
compatible string. To be more precise look at the possible DSDT excerpt
below:

	Device (LDX0) {
		Name (_HID, "PRP0001")
		Name (_DDN, "TI LP3952 compatible led driver")
		...
	})

	Name (_DSD, Package () {
		ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
		Package () {
			Package () {"compatible", "ti,lp3952"},
			...
		}
	})

Based on above, remove non-official ACPI IDs and enumeration from the
driver.

Note: currently driver has no compatible strings at all, to make above
working one should add at least one.

[1] https://e2e.ti.com/support/power_management/led_driver/f/192/t/524926
[2] https://www.spinics.net/lists/linux-acpi/msg67125.html

Cc: Tony Makkiel <tony.makkiel@daqri.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
parent ac572452
...@@ -249,7 +249,6 @@ config LEDS_LP3952 ...@@ -249,7 +249,6 @@ config LEDS_LP3952
tristate "LED Support for TI LP3952 2 channel LED driver" tristate "LED Support for TI LP3952 2 channel LED driver"
depends on LEDS_CLASS depends on LEDS_CLASS
depends on I2C depends on I2C
depends on ACPI
depends on GPIOLIB depends on GPIOLIB
select REGMAP_I2C select REGMAP_I2C
help help
......
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
* *
*/ */
#include <linux/acpi.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/gpio.h> #include <linux/gpio.h>
#include <linux/i2c.h> #include <linux/i2c.h>
...@@ -276,19 +275,9 @@ static const struct i2c_device_id lp3952_id[] = { ...@@ -276,19 +275,9 @@ static const struct i2c_device_id lp3952_id[] = {
}; };
MODULE_DEVICE_TABLE(i2c, lp3952_id); MODULE_DEVICE_TABLE(i2c, lp3952_id);
#ifdef CONFIG_ACPI
static const struct acpi_device_id lp3952_acpi_match[] = {
{"TXNW3952", 0},
{}
};
MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
#endif
static struct i2c_driver lp3952_i2c_driver = { static struct i2c_driver lp3952_i2c_driver = {
.driver = { .driver = {
.name = LP3952_NAME, .name = LP3952_NAME,
.acpi_match_table = ACPI_PTR(lp3952_acpi_match),
}, },
.probe = lp3952_probe, .probe = lp3952_probe,
.remove = lp3952_remove, .remove = lp3952_remove,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment