Commit 97944769 authored by Roger Quadros's avatar Roger Quadros Committed by Greg Kroah-Hartman

usb: cdns3: Error out if USB_DR_MODE_UNKNOWN in cdns3_core_init_role()

USB_DR_MODE_UNKNOWN should be treated as error as it is done in
cdns3_drd_update_mode().

Fixes: 02ffc26d ("usb: cdns3: fix cdns3_core_init_role()")
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Link: https://lore.kernel.org/r/20191017075801.8734-1-rogerq@ti.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a6f22d7
...@@ -166,7 +166,6 @@ static int cdns3_core_init_role(struct cdns3 *cdns) ...@@ -166,7 +166,6 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
goto err; goto err;
switch (cdns->dr_mode) { switch (cdns->dr_mode) {
case USB_DR_MODE_UNKNOWN:
case USB_DR_MODE_OTG: case USB_DR_MODE_OTG:
ret = cdns3_hw_role_switch(cdns); ret = cdns3_hw_role_switch(cdns);
if (ret) if (ret)
...@@ -182,6 +181,9 @@ static int cdns3_core_init_role(struct cdns3 *cdns) ...@@ -182,6 +181,9 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
if (ret) if (ret)
goto err; goto err;
break; break;
default:
ret = -EINVAL;
goto err;
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment