Commit 98c69fcc authored by Mark Brown's avatar Mark Brown

Merge series "ASoC: SOF/Intel: fix and remove Sparse warnings" from...

Merge series "ASoC: SOF/Intel: fix and remove Sparse warnings" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:

We updated our SOF CI settings last week (see below) to use more options
for Sparse, and sure enough it detected one nasty single-character bug
in one of my previous patches, along with more trivial issues with
string/integer sizes and signed/unsigned confusions.

export ARCH=x86_64
export CF="-Wsparse-error -Wsparse-all -Wno-bitwise-pointer -Wno-pointer-arith -Wno-typesign -Wnoshadow"
make -k sound/soc/sof/ C=2
make -k sound/soc/intel/common/ C=2
make -k sound/soc/intel/boards/ C=2
make -k drivers/soundwire/ C=2

Pierre-Louis Bossart (9):
  ASoC: SOF: Intel: hda: fix index used in inner loop
  ASoC: Intel: sof_rt5682: shrink platform_id names below 20 characters
  ASoC: Intel: sof_cs42l42: shrink platform id below 20 characters
  ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20
    characters
  ASoC: Intel: glk_rt5682_max98357a: shrink platform_id below 20
    characters
  ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20
    characters
  ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20
    characters
  ASoC: Intel: sof_sdw: fix signed/unsigned warning
  ASoC: Intel: soc-acpi: add ull suffix for SoundWire _ADR values

 sound/soc/intel/boards/bxt_da7219_max98357a.c | 12 +++---
 sound/soc/intel/boards/glk_rt5682_max98357a.c |  4 +-
 sound/soc/intel/boards/kbl_da7219_max98357a.c |  4 +-
 sound/soc/intel/boards/sof_cs42l42.c          |  2 +-
 sound/soc/intel/boards/sof_da7219_max98373.c  |  8 ++--
 sound/soc/intel/boards/sof_rt5682.c           | 20 +++++-----
 sound/soc/intel/boards/sof_sdw.c              |  2 +-
 .../intel/common/soc-acpi-intel-adl-match.c   | 28 +++++++-------
 .../intel/common/soc-acpi-intel-bxt-match.c   |  2 +-
 .../intel/common/soc-acpi-intel-cml-match.c   | 22 +++++------
 .../intel/common/soc-acpi-intel-cnl-match.c   |  2 +-
 .../intel/common/soc-acpi-intel-glk-match.c   |  6 +--
 .../intel/common/soc-acpi-intel-icl-match.c   | 12 +++---
 .../intel/common/soc-acpi-intel-jsl-match.c   |  6 +--
 .../intel/common/soc-acpi-intel-kbl-match.c   |  2 +-
 .../intel/common/soc-acpi-intel-tgl-match.c   | 38 +++++++++----------
 sound/soc/sof/intel/hda.c                     |  2 +-
 17 files changed, 86 insertions(+), 86 deletions(-)

--
2.25.1
parents c9f2e3c3 24e46fb8
...@@ -840,9 +840,9 @@ static int broxton_audio_probe(struct platform_device *pdev) ...@@ -840,9 +840,9 @@ static int broxton_audio_probe(struct platform_device *pdev)
} }
static const struct platform_device_id bxt_board_ids[] = { static const struct platform_device_id bxt_board_ids[] = {
{ .name = "bxt_da7219_max98357a" }, { .name = "bxt_da7219_mx98357a" },
{ .name = "glk_da7219_max98357a" }, { .name = "glk_da7219_mx98357a" },
{ .name = "cml_da7219_max98357a" }, { .name = "cml_da7219_mx98357a" },
{ } { }
}; };
...@@ -866,7 +866,7 @@ MODULE_AUTHOR("Naveen Manohar <naveen.m@intel.com>"); ...@@ -866,7 +866,7 @@ MODULE_AUTHOR("Naveen Manohar <naveen.m@intel.com>");
MODULE_AUTHOR("Mac Chiang <mac.chiang@intel.com>"); MODULE_AUTHOR("Mac Chiang <mac.chiang@intel.com>");
MODULE_AUTHOR("Brent Lu <brent.lu@intel.com>"); MODULE_AUTHOR("Brent Lu <brent.lu@intel.com>");
MODULE_LICENSE("GPL v2"); MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:bxt_da7219_max98357a"); MODULE_ALIAS("platform:bxt_da7219_mx98357a");
MODULE_ALIAS("platform:glk_da7219_max98357a"); MODULE_ALIAS("platform:glk_da7219_mx98357a");
MODULE_ALIAS("platform:cml_da7219_max98357a"); MODULE_ALIAS("platform:cml_da7219_mx98357a");
MODULE_IMPORT_NS(SND_SOC_INTEL_HDA_DSP_COMMON); MODULE_IMPORT_NS(SND_SOC_INTEL_HDA_DSP_COMMON);
...@@ -480,7 +480,7 @@ static int sof_audio_probe(struct platform_device *pdev) ...@@ -480,7 +480,7 @@ static int sof_audio_probe(struct platform_device *pdev)
static const struct platform_device_id board_ids[] = { static const struct platform_device_id board_ids[] = {
{ {
.name = "glk_cs4242_max98357a", .name = "glk_cs4242_mx98357a",
.driver_data = (kernel_ulong_t)(SOF_CS42L42_SSP_CODEC(2) | .driver_data = (kernel_ulong_t)(SOF_CS42L42_SSP_CODEC(2) |
SOF_SPEAKER_AMP_PRESENT | SOF_SPEAKER_AMP_PRESENT |
SOF_MAX98357A_SPEAKER_AMP_PRESENT | SOF_MAX98357A_SPEAKER_AMP_PRESENT |
......
...@@ -56,7 +56,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_bxt_machines[] = { ...@@ -56,7 +56,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_bxt_machines[] = {
}, },
{ {
.id = "DLGS7219", .id = "DLGS7219",
.drv_name = "bxt_da7219_max98357a", .drv_name = "bxt_da7219_mx98357a",
.fw_filename = "intel/dsp_fw_bxtn.bin", .fw_filename = "intel/dsp_fw_bxtn.bin",
.machine_quirk = snd_soc_acpi_codec_list, .machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &bxt_codecs, .quirk_data = &bxt_codecs,
......
...@@ -67,7 +67,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_machines[] = { ...@@ -67,7 +67,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_machines[] = {
}, },
{ {
.id = "DLGS7219", .id = "DLGS7219",
.drv_name = "cml_da7219_max98357a", .drv_name = "cml_da7219_mx98357a",
.machine_quirk = snd_soc_acpi_codec_list, .machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &max98357a_spk_codecs, .quirk_data = &max98357a_spk_codecs,
.sof_fw_filename = "sof-cml.ri", .sof_fw_filename = "sof-cml.ri",
......
...@@ -24,7 +24,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = { ...@@ -24,7 +24,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
}, },
{ {
.id = "DLGS7219", .id = "DLGS7219",
.drv_name = "glk_da7219_max98357a", .drv_name = "glk_da7219_mx98357a",
.fw_filename = "intel/dsp_fw_glk.bin", .fw_filename = "intel/dsp_fw_glk.bin",
.machine_quirk = snd_soc_acpi_codec_list, .machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &glk_codecs, .quirk_data = &glk_codecs,
...@@ -42,7 +42,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = { ...@@ -42,7 +42,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
}, },
{ {
.id = "10134242", .id = "10134242",
.drv_name = "glk_cs4242_max98357a", .drv_name = "glk_cs4242_mx98357a",
.fw_filename = "intel/dsp_fw_glk.bin", .fw_filename = "intel/dsp_fw_glk.bin",
.machine_quirk = snd_soc_acpi_codec_list, .machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &glk_codecs, .quirk_data = &glk_codecs,
......
...@@ -1069,7 +1069,7 @@ static bool link_slaves_found(struct snd_sof_dev *sdev, ...@@ -1069,7 +1069,7 @@ static bool link_slaves_found(struct snd_sof_dev *sdev,
/* find out how many identical parts are expected */ /* find out how many identical parts are expected */
for (k = 0; k < link->num_adr; k++) { for (k = 0; k < link->num_adr; k++) {
u64 adr2 = link->adr_d[i].adr; u64 adr2 = link->adr_d[k].adr;
unsigned int part_id2, link_id2, mfg_id2; unsigned int part_id2, link_id2, mfg_id2;
mfg_id2 = SDW_MFG_ID(adr2); mfg_id2 = SDW_MFG_ID(adr2);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment