Commit 991fcb77 authored by Lyude Paul's avatar Lyude Paul

drm/edid: Fix uninitialized variable in drm_cvt_modes()

Noticed this when trying to compile with -Wall on a kernel fork. We
potentially don't set width here, which causes the compiler to complain
about width potentially being uninitialized in drm_cvt_modes(). So, let's
fix that.

Changes since v1:
* Don't emit an error as this code isn't reachable, just mark it as such
Changes since v2:
* Remove now unused variable

Fixes: 3f649ab7 ("treewide: Remove uninitialized_var() usage")
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Reviewed-by: default avatarIlia Mirkin <imirkin@alum.mit.edu>
Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@redhat.com
parent 1528bfcf
...@@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector, ...@@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector,
case 0x0c: case 0x0c:
width = height * 15 / 9; width = height * 15 / 9;
break; break;
default:
unreachable();
} }
for (j = 1; j < 5; j++) { for (j = 1; j < 5; j++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment