Commit 996ef312 authored by Luis Chamberlain's avatar Luis Chamberlain

sysctl: remove empty dev table

Now that all the dev sysctls have been moved out we can remove the
dev sysctl base directory. We don't need to create base directories,
they are created for you as if using 'mkdir -p' with register_syctl()
and register_sysctl_init(). For details refer to sysctl_mkdir_p()
usage.

We save 90 bytes with this changes:

./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remove-dev-table
add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90)
Function                                     old     new   delta
sysctl_init_bases                            111      85     -26
dev_table                                     64       -     -64
Total: Before=21257057, After=21256967, chg -0.00%

The empty dev table has been in place since the v2.5.0 days because
back then ordering was essentialy. But later commit 7ec66d06
("sysctl: Stop requiring explicit management of sysctl directories"),
merged as of v3.4-rc1, the entire ordering of directories was replaced
by allowing sysctl directory autogeneration. This new mechanism
introduced on v3.4 allows for sysctl directories to automatically be
created for sysctl tables when they are needed and automatically removes
them when no sysctl tables use them. That commit also added a dedicated
struct ctl_dir as a new type for these autogenerated directories.
Reviewed-by: default avatarJoel Granados <j.granados@samsung.com>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent b8cbc085
...@@ -2332,10 +2332,6 @@ static struct ctl_table debug_table[] = { ...@@ -2332,10 +2332,6 @@ static struct ctl_table debug_table[] = {
{ } { }
}; };
static struct ctl_table dev_table[] = {
{ }
};
int __init sysctl_init_bases(void) int __init sysctl_init_bases(void)
{ {
register_sysctl_init("kernel", kern_table); register_sysctl_init("kernel", kern_table);
...@@ -2346,7 +2342,6 @@ int __init sysctl_init_bases(void) ...@@ -2346,7 +2342,6 @@ int __init sysctl_init_bases(void)
register_sysctl_init("vm", vm_table); register_sysctl_init("vm", vm_table);
register_sysctl_init("debug", debug_table); register_sysctl_init("debug", debug_table);
register_sysctl_init("dev", dev_table);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment