Commit 999340d5 authored by Chen Jun's avatar Chen Jun Committed by Steven Rostedt (VMware)

ftrace: Have recordmcount use w8 to read relp->r_info in arm64_is_fake_mcount

On little endian system, Use aarch64_be(gcc v7.3) downloaded from
linaro.org to build image with CONFIG_CPU_BIG_ENDIAN = y,
CONFIG_FTRACE = y, CONFIG_DYNAMIC_FTRACE = y.

gcc will create symbols of _mcount but recordmcount can not create
mcount_loc for *.o.
aarch64_be-linux-gnu-objdump -r fs/namei.o | grep mcount
00000000000000d0 R_AARCH64_CALL26  _mcount
...
0000000000007190 R_AARCH64_CALL26  _mcount

The reason is than funciton arm64_is_fake_mcount can not work correctly.
A symbol of _mcount in *.o compiled with big endian compiler likes:
00 00 00 2d 00 00 01 1b
w(rp->r_info) will return 0x2d instead of 0x011b. Because w() takes
uint32_t as parameter, which truncates rp->r_info.

Use w8() instead w() to read relp->r_info

Link: https://lkml.kernel.org/r/20210222135840.56250-1-chenjun102@huawei.com

Fixes: ea0eada4 ("recordmcount: only record relocation of type R_AARCH64_CALL26 on arm64.")
Acked-by: default avatarWill Deacon <will@kernel.org>
Signed-off-by: default avatarChen Jun <chenjun102@huawei.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent fe07bfda
...@@ -438,7 +438,7 @@ static int arm_is_fake_mcount(Elf32_Rel const *rp) ...@@ -438,7 +438,7 @@ static int arm_is_fake_mcount(Elf32_Rel const *rp)
static int arm64_is_fake_mcount(Elf64_Rel const *rp) static int arm64_is_fake_mcount(Elf64_Rel const *rp)
{ {
return ELF64_R_TYPE(w(rp->r_info)) != R_AARCH64_CALL26; return ELF64_R_TYPE(w8(rp->r_info)) != R_AARCH64_CALL26;
} }
/* 64-bit EM_MIPS has weird ELF64_Rela.r_info. /* 64-bit EM_MIPS has weird ELF64_Rela.r_info.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment