Commit 99d31cbd authored by Aya Levin's avatar Aya Levin Committed by Saeed Mahameed

net/mlx5e: Fix error flow in tx reporter diagnose

Fix tx reporter's diagnose callback. Propagate error when failing to
gather diagnostics information or failing to print diagnostic data per
queue.

Fixes: de8650a8 ("net/mlx5e: Add tx reporter support")
Signed-off-by: default avatarAya Levin <ayal@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 39825350
...@@ -262,13 +262,13 @@ static int mlx5e_tx_reporter_diagnose(struct devlink_health_reporter *reporter, ...@@ -262,13 +262,13 @@ static int mlx5e_tx_reporter_diagnose(struct devlink_health_reporter *reporter,
err = mlx5_core_query_sq_state(priv->mdev, sq->sqn, &state); err = mlx5_core_query_sq_state(priv->mdev, sq->sqn, &state);
if (err) if (err)
break; goto unlock;
err = mlx5e_tx_reporter_build_diagnose_output(fmsg, sq->sqn, err = mlx5e_tx_reporter_build_diagnose_output(fmsg, sq->sqn,
state, state,
netif_xmit_stopped(sq->txq)); netif_xmit_stopped(sq->txq));
if (err) if (err)
break; goto unlock;
} }
err = devlink_fmsg_arr_pair_nest_end(fmsg); err = devlink_fmsg_arr_pair_nest_end(fmsg);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment