Commit 99d84bf8 authored by Peter Zijlstra's avatar Peter Zijlstra

stop_machine: Fix stop_cpus_in_progress ordering

Make sure the entire for loop has stop_cpus_in_progress set.
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Aaron Lu <aaron.lwe@gmail.com>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: mingo@kernel.org
Cc: Phil Auld <pauld@redhat.com>
Cc: Julien Desfossez <jdesfossez@digitalocean.com>
Cc: Nishanth Aravamudan <naravamudan@digitalocean.com>
Link: https://lkml.kernel.org/r/0fd8fd4b99b9b9aa88d8b2dff897f7fd0d88f72c.1559129225.git.vpillai@digitalocean.com
parent de53fd7a
...@@ -383,6 +383,7 @@ static bool queue_stop_cpus_work(const struct cpumask *cpumask, ...@@ -383,6 +383,7 @@ static bool queue_stop_cpus_work(const struct cpumask *cpumask,
*/ */
preempt_disable(); preempt_disable();
stop_cpus_in_progress = true; stop_cpus_in_progress = true;
barrier();
for_each_cpu(cpu, cpumask) { for_each_cpu(cpu, cpumask) {
work = &per_cpu(cpu_stopper.stop_work, cpu); work = &per_cpu(cpu_stopper.stop_work, cpu);
work->fn = fn; work->fn = fn;
...@@ -391,6 +392,7 @@ static bool queue_stop_cpus_work(const struct cpumask *cpumask, ...@@ -391,6 +392,7 @@ static bool queue_stop_cpus_work(const struct cpumask *cpumask,
if (cpu_stop_queue_work(cpu, work)) if (cpu_stop_queue_work(cpu, work))
queued = true; queued = true;
} }
barrier();
stop_cpus_in_progress = false; stop_cpus_in_progress = false;
preempt_enable(); preempt_enable();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment