Commit 9acb9f0e authored by Xuezhi Zhang's avatar Xuezhi Zhang Committed by Martin K. Petersen

scsi: csiostor: Convert sysfs snprintf() to sysfs_emit()

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.

Link: https://lore.kernel.org/r/20220901015130.419307-1-zhangxuezhi3@gmail.comReviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarXuezhi Zhang <zhangxuezhi1@coolpad.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 68a97feb
...@@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev, ...@@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev,
struct csio_hw *hw = csio_lnode_to_hw(ln); struct csio_hw *hw = csio_lnode_to_hw(ln);
if (csio_is_hw_ready(hw)) if (csio_is_hw_ready(hw))
return snprintf(buf, PAGE_SIZE, "ready\n"); return sysfs_emit(buf, "ready\n");
else
return snprintf(buf, PAGE_SIZE, "not ready\n"); return sysfs_emit(buf, "not ready\n");
} }
/* Device reset */ /* Device reset */
...@@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev, ...@@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev,
{ {
struct csio_lnode *ln = shost_priv(class_to_shost(dev)); struct csio_lnode *ln = shost_priv(class_to_shost(dev));
return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level); return sysfs_emit(buf, "%x\n", ln->params.log_level);
} }
/* Store debug level */ /* Store debug level */
...@@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev, ...@@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev,
{ {
struct csio_lnode *ln = shost_priv(class_to_shost(dev)); struct csio_lnode *ln = shost_priv(class_to_shost(dev));
return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes); return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes);
} }
static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL); static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment