Commit 9b40afc4 authored by Jérôme Glisse's avatar Jérôme Glisse Committed by Stefan Bader

block: do not leak memory in bio_copy_user_iov()

BugLink: https://bugs.launchpad.net/bugs/1828420

commit a3761c3c upstream.

When bio_add_pc_page() fails in bio_copy_user_iov() we should free
the page we just allocated otherwise we are leaking it.

Cc: linux-block@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarJérôme Glisse <jglisse@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
parent 3b90a4b0
...@@ -1216,8 +1216,11 @@ struct bio *bio_copy_user_iov(struct request_queue *q, ...@@ -1216,8 +1216,11 @@ struct bio *bio_copy_user_iov(struct request_queue *q,
} }
} }
if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes) if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes) {
if (!map_data)
__free_page(page);
break; break;
}
len -= bytes; len -= bytes;
offset = 0; offset = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment