Commit 9c7b4e8a authored by Russ Dill's avatar Russ Dill Committed by Mark Brown

regulator: Fix memory garbage dev_err printout.

commit dd8004af: 'regulator: core: Log when a device causes a voltage
constraint fail', tried to print out some information about the
check consumer min/max uV fixup, however, it uses a garbage pointer
left over from list_for_each_entry leading to boot messages in the
form:

'[    2.079890] <RANDOM ASCII>: Restricting voltage, 3735899821-4294967295uV'

Because it references regulator->dev, it could potentially read memory from
anywhere causing a panic.

This patch instead uses rdev and the updated min/max uV values.
Signed-off-by: default avatarRuss Dill <Russ.Dill@ti.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent f2e5d078
...@@ -200,8 +200,8 @@ static int regulator_check_consumers(struct regulator_dev *rdev, ...@@ -200,8 +200,8 @@ static int regulator_check_consumers(struct regulator_dev *rdev,
} }
if (*min_uV > *max_uV) { if (*min_uV > *max_uV) {
dev_err(regulator->dev, "Restricting voltage, %u-%uuV\n", rdev_err(rdev, "Restricting voltage, %u-%uuV\n",
regulator->min_uV, regulator->max_uV); *min_uV, *max_uV);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment