Commit 9ca01c7a authored by Ard Biesheuvel's avatar Ard Biesheuvel

efivarfs: Drop redundant cleanup on fill_super() failure

Al points out that kill_sb() will be called if efivarfs_fill_super()
fails and so there is no point in cleaning up the efivar entry list.
Reported-by: default avatarAlexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent f45812cc
...@@ -343,12 +343,7 @@ static int efivarfs_fill_super(struct super_block *sb, struct fs_context *fc) ...@@ -343,12 +343,7 @@ static int efivarfs_fill_super(struct super_block *sb, struct fs_context *fc)
if (err) if (err)
return err; return err;
err = efivar_init(efivarfs_callback, (void *)sb, true, return efivar_init(efivarfs_callback, sb, true, &sfi->efivarfs_list);
&sfi->efivarfs_list);
if (err)
efivar_entry_iter(efivarfs_destroy, &sfi->efivarfs_list, NULL);
return err;
} }
static int efivarfs_get_tree(struct fs_context *fc) static int efivarfs_get_tree(struct fs_context *fc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment