Commit 9cda3007 authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman

staging: most: remove reference counter

This patch removes the unnecessary reference conter mod_ref.
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6ed90e36
...@@ -35,7 +35,6 @@ ...@@ -35,7 +35,6 @@
static struct class *most_class; static struct class *most_class;
static struct device *class_glue_dir; static struct device *class_glue_dir;
static struct ida mdev_id; static struct ida mdev_id;
static int modref;
static int dummy_num_buffers; static int dummy_num_buffers;
struct most_c_aim_obj { struct most_c_aim_obj {
...@@ -1508,7 +1507,6 @@ int most_start_channel(struct most_interface *iface, int id, ...@@ -1508,7 +1507,6 @@ int most_start_channel(struct most_interface *iface, int id,
mutex_unlock(&c->start_mutex); mutex_unlock(&c->start_mutex);
return -ENOLCK; return -ENOLCK;
} }
modref++;
c->cfg.extra_len = 0; c->cfg.extra_len = 0;
if (c->iface->configure(c->iface, c->channel_id, &c->cfg)) { if (c->iface->configure(c->iface, c->channel_id, &c->cfg)) {
...@@ -1550,7 +1548,6 @@ int most_start_channel(struct most_interface *iface, int id, ...@@ -1550,7 +1548,6 @@ int most_start_channel(struct most_interface *iface, int id,
error: error:
module_put(iface->mod); module_put(iface->mod);
modref--;
mutex_unlock(&c->start_mutex); mutex_unlock(&c->start_mutex);
return ret; return ret;
} }
...@@ -1584,10 +1581,8 @@ int most_stop_channel(struct most_interface *iface, int id, ...@@ -1584,10 +1581,8 @@ int most_stop_channel(struct most_interface *iface, int id,
c->hdm_enqueue_task = NULL; c->hdm_enqueue_task = NULL;
mutex_unlock(&c->stop_task_mutex); mutex_unlock(&c->stop_task_mutex);
if (iface->mod && modref) { if (iface->mod)
module_put(iface->mod); module_put(iface->mod);
modref--;
}
c->is_poisoned = true; c->is_poisoned = true;
if (c->iface->poison_channel(c->iface, c->channel_id)) { if (c->iface->poison_channel(c->iface, c->channel_id)) {
...@@ -1808,12 +1803,6 @@ void most_deregister_interface(struct most_interface *iface) ...@@ -1808,12 +1803,6 @@ void most_deregister_interface(struct most_interface *iface)
c->aim1.ptr = NULL; c->aim1.ptr = NULL;
} }
while (modref) {
if (iface->mod && modref)
module_put(iface->mod);
modref--;
}
list_for_each_entry(c, &i->channel_list, list) { list_for_each_entry(c, &i->channel_list, list) {
if (c->aim0.refs + c->aim1.refs <= 0) if (c->aim0.refs + c->aim1.refs <= 0)
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment