Commit 9d2fe9ae authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab

[media] DaVinci-VPBE: Return an error code only as a constant in vpbe_probe()

* Return an error code without storing it in an intermediate variable.

* Delete the local variable "ret" which became unnecessary with
  this refactoring.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 13538751
...@@ -818,7 +818,6 @@ static int vpbe_probe(struct platform_device *pdev) ...@@ -818,7 +818,6 @@ static int vpbe_probe(struct platform_device *pdev)
{ {
struct vpbe_device *vpbe_dev; struct vpbe_device *vpbe_dev;
struct vpbe_config *cfg; struct vpbe_config *cfg;
int ret = -EINVAL;
if (!pdev->dev.platform_data) { if (!pdev->dev.platform_data) {
v4l2_err(pdev->dev.driver, "No platform data\n"); v4l2_err(pdev->dev.driver, "No platform data\n");
...@@ -830,7 +829,7 @@ static int vpbe_probe(struct platform_device *pdev) ...@@ -830,7 +829,7 @@ static int vpbe_probe(struct platform_device *pdev)
!cfg->osd.module_name[0] || !cfg->osd.module_name[0] ||
!cfg->venc.module_name[0]) { !cfg->venc.module_name[0]) {
v4l2_err(pdev->dev.driver, "vpbe display module names not defined\n"); v4l2_err(pdev->dev.driver, "vpbe display module names not defined\n");
return ret; return -EINVAL;
} }
vpbe_dev = kzalloc(sizeof(*vpbe_dev), GFP_KERNEL); vpbe_dev = kzalloc(sizeof(*vpbe_dev), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment